Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Release/version bump to 1.23.0, updating addon metadata and refining UI/logging/test behavior to support recent feature work (action bar color support, Nexo integration, locale updates, and code quality improvements).
Changes:
- Bump project version to 1.23.0 and update addon API metadata.
- Refactor
PhasesPanelandOneBlocksManager#getProbs()to reduce complexity and improve maintainability. - Update tests to align with Adventure
Titleusage and add additional safety assertions.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/world/bentobox/aoneblock/TestWorldSettings.java | Add explicit no-op comment in stubbed method. |
| src/test/java/world/bentobox/aoneblock/listeners/StartSafetyListenerTest.java | Add explicit no-op comments in stubbed methods. |
| src/test/java/world/bentobox/aoneblock/listeners/CheckPhaseTest.java | Update assertions to verify Adventure Title usage. |
| src/test/java/world/bentobox/aoneblock/listeners/BlockListenerTest2.java | Tighten tests with assertDoesNotThrow; minor visibility tweak. |
| src/main/resources/addon.yml | Update declared BentoBox api-version. |
| src/main/java/world/bentobox/aoneblock/panels/PhasesPanel.java | Refactor phase button creation into helper methods; simplify formatting logic. |
| src/main/java/world/bentobox/aoneblock/oneblocks/OneBlocksManager.java | Refactor probability logging into smaller helper methods. |
| src/main/java/world/bentobox/aoneblock/listeners/CheckPhase.java | Switch to Adventure titles and component-based requirement messages. |
| pom.xml | Bump build version to 1.23.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/world/bentobox/aoneblock/listeners/CheckPhase.java
Outdated
Show resolved
Hide resolved
|
@tastybento I've opened a new pull request, #485, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@tastybento I've opened a new pull request, #486, to work on those changes. Once the pull request is ready, I'll request review from you. |
…custom translate() with LegacyComponentSerializer Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/3ae91a34-99b8-44ae-bdce-bc776883a2f9 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
…port Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/8ff2ce9e-417f-45e9-92d3-d6649871f7c7 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Bump BentoBox dependency to 3.13.0 for MiniMessage support
… LegacyComponentSerializer) Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/e8854ea2-7b56-497a-ac76-533846ce7957 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
…t.sendMessage() Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/b792d2e9-3944-46fa-9f8e-2339f94967e8 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove custom translate() helper from CheckPhase — let BentoBox handle MiniMessage natively
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot apply changes based on the comments in this thread Put them all in to a PR to this one as they are all essentially similar checks. |
|
@tastybento I've opened a new pull request, #487, to work on those changes. Once the pull request is ready, I'll request review from you. |
Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/e4ba8fa5-e639-4f8e-ae85-ae03b1d9c5ff Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/e4ba8fa5-e639-4f8e-ae85-ae03b1d9c5ff Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Strengthen Title assertions in CheckPhaseTest with ArgumentCaptor
|
Summary
Changes since 1.22.0
Test plan
mvn test)🤖 Generated with Claude Code